-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ADR-204 new comms architecture #272
Conversation
Deploying adr with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @pentreathm
Hi, how are you? Great work @pentreathm! I have just a few questions:
|
Co-authored-by: Alejo Thomas Ortega <[email protected]> Signed-off-by: pentreathm <[email protected]>
Co-authored-by: Ignacio Mazzara <[email protected]> Signed-off-by: pentreathm <[email protected]>
A user should always be connected to only one scene at a time, only one scene connection should remain open.
Indeed, this feature will be lost in this initial version, it was a necessary trade-off in the design to give scene owners greater control over audio streams and the ability to moderate content. That said, there is potential for improvements. For instance, if a user is connected to Archipelago but not to a specific Scene, they could leverage that channel to share audio, enabling this use case. Additionally, a future "party mode" could be developed using the comms gatekeeper, allowing users to create a private communication channel with friends. This would facilitate sharing audio and text chat, irrespective of other connections in the environment.
yes, and I agree with your point, however, the decision was made because text chat is generally less intrusive for other users compared to voice chat. With voice, individuals can disrupt the experience for others, whereas text chat can simply be muted or turned off when needed. cc @kuruk-mm |
Co-authored-by: Alejo Thomas Ortega <[email protected]> Signed-off-by: pentreathm <[email protected]>
Co-authored-by: Alejo Thomas Ortega <[email protected]> Signed-off-by: pentreathm <[email protected]>
* Describe Compression and Encoding algorithms Signed-off-by: Mikhail Agapov <[email protected]>
Co-authored-by: Aga <[email protected]> Signed-off-by: pentreathm <[email protected]>
Signed-off-by: pentreathm <[email protected]>
Should we also mark the older comms ADR as deprecated as we introduced the new state? |
Only after this had lived for at least year (or a period that makes sense) I'd set the current comms as deprecated. There is no rush; this is still experimental and not implemented by other clients except by the new Unity Explorer. |
Co-authored-by: Aga <[email protected]> Signed-off-by: pentreathm <[email protected]>
Agree, there is definitely no rush, just would like to avoid situation when potential new clients start using the old version of the comms. |
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: pentreathm <[email protected]>
Signed-off-by: pentreathm <[email protected]>
No description provided.