Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Version 1.4 #5

Closed
wants to merge 36 commits into from

Conversation

dancingcactus
Copy link

Refactored the code to work with Adobe's API version 1.4

  • Works with API 1.4
  • Trended Reports now work in all cases (Resolves Improve Report#data for trended reports. #2 )
  • Added some unit tests
  • Added a build script
  • Finished Pandas Support
  • Added more report options
    ** Current Data
    ** Inline segments (rough support)
  • Added docs strings for help in ipython
  • Added user-friendly print statements
  • Added a liscence file to match the stated lisence in the module
  • Added logging

* Added api 1.4 support
* Added support for SortBy
* Added support for currentData
* Finished Pandas support
* Rewrote response parser
* Added a run method to a report
* Added unit tests
* Added logging
* Added lots of doc string
* Made print a bit more useful
* Allow query.metric and query.element to be called multiple times
* Added breakdown method to query
Adding a License to the repo in addition to the one specified in the setup.py
* Cleaned up the code a bit to remove some old classes that weren't being
used.
* Updated the README.md file to be inline with the new changes
* Renamed the test cases to be the right name
Updated install instructions
Allow you to pass in Segment IDs to the report

class OverTimeReport(Report):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new version of the API the different reports are all queued and returned the same way so there isn't a need for the different types

@debrouwere
Copy link
Owner

Pretty awesome stuff, thanks! I'm not really using Omniture with any of my current clients so it'll be kind of hard for me to test this, but I'll try to give it a quick review and then merge.

@dancingcactus
Copy link
Author

Thanks Stijn. I have been using this more and more over the past few weeks and I think I have found a few bugs especially related to mutli-byte characters. Let me update those before you merge. Also if you need an Omniture/Adobe account I think you can get a sandbox account setup (https://marketing.adobe.com/developer/en_US/devcenter). You just have to register and fill out their form.

@debrouwere
Copy link
Owner

Did you hit any more multi-byte character bugs, @dancingcactus? Was thinking of finally merging in some of these pull requests :-)

@dancingcactus
Copy link
Author

I did, and a few other bugs. Let me merge those into the pull request in the next day or so.

@debrouwere
Copy link
Owner

Splendid. No rush. Thanks so much for your work on this.

@dancingcactus
Copy link
Author

Alright I think. Those are all of the bug fixes and improvements I have made over the past few weeks. It should be ready.

@dancingcactus dancingcactus deleted the 1_4update branch March 2, 2017 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Report#data for trended reports.
2 participants