Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add Dzongkha #741

Merged
merged 4 commits into from
Oct 4, 2024
Merged

[FEAT] Add Dzongkha #741

merged 4 commits into from
Oct 4, 2024

Conversation

KinWang-2013
Copy link
Contributor

@KinWang-2013 KinWang-2013 commented Oct 3, 2024

This PR adds Dzongkha, the national Language of Bhutan 🇧🇹

@KinWang-2013 KinWang-2013 changed the title add dzongkha [FEAT] Add Dzongkha Oct 3, 2024
@KinWang-2013 KinWang-2013 marked this pull request as ready for review October 3, 2024 06:45
gem/locales/dz.yml Outdated Show resolved Hide resolved
@benkoshy
Copy link
Collaborator

benkoshy commented Oct 4, 2024

Hi @KinWang-2013

Thank you for your PR

  • Please confirm that this is a :one_other pluralization? I couldn't find dz in the list here and was wanting to double check to be sure?

@KinWang-2013
Copy link
Contributor Author

Hi @KinWang-2013

Thank you for your PR

  • Please confirm that this is a :one_other pluralization? I couldn't find dz in the list here and was wanting to double check to be sure?

yes it is. I will make a PR there as well

@ddnexus ddnexus changed the base branch from master to dev October 4, 2024 05:35
gem/locales/dz.yml Outdated Show resolved Hide resolved
@ddnexus
Copy link
Owner

ddnexus commented Oct 4, 2024

yes it is. I will make a PR there as well

From the entries in the dictionary, it doesn't look like the pluralization rule is :one_other, since they show the same translation. It looks more like :other. Please, link an official page for the dz locale that shows which pluralization rule applies, and fix either the rule or the entries.

Thank you.

@KinWang-2013
Copy link
Contributor Author

yes it is. I will make a PR there as well

From the entries in the dictionary, it doesn't look like the pluralization rule is :one_other, since they show the same translation. It looks more like :other. Please, link an official page for the dz locale that shows which pluralization rule applies, and fix either the rule or the entries.

Thank you.

sorry, got a bit confused, will update, I don't think there are any official page for dz locale.

@ddnexus
Copy link
Owner

ddnexus commented Oct 4, 2024

Maybe we can link https://www.unicode.org/cldr/charts/45/supplemental/language_plural_rules.html at the top of the dz dictionary file.

Sorry, the reference is not needed in the file. Here is enough: https://www.unicode.org/cldr/charts/45/supplemental/language_plural_rules.html

@ddnexus ddnexus merged commit 2570e14 into ddnexus:dev Oct 4, 2024
8 of 9 checks passed
@ddnexus
Copy link
Owner

ddnexus commented Oct 4, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants