Add Vietnamese locale

[YutoYasunaga]

Thank you for the great project,
I've added Vietnamese locale

Result:

[benkoshy]

YutoYasunaga thank you for your contribution!

It will take some time for me to assess / understand how locales work etc.

I will get back to you in time.

[benkoshy]

Hi Yuto

Thank you for your contribution! Apologies for the delay.

A couple of things are are required to finalize the merge. (Noted here: https://github.com/ddnexus/pagy/blob/master/lib/locales/README.md)

• We would need to add to the hash here:
  

  pagy/lib/pagy/i18n.rb

  Line 95 in e237479

  LOCALE = Hash.new(RULE[:one_other]).tap do |hash|

• It looks like you've matched all the keys well which is great! Here is an example in Japanese which uses the "other" pluralization which you've already matched perfectly: https://github.com/ddnexus/pagy/blob/master/lib/locales/ja.yml

[YutoYasunaga]

Thank you for your feedback and detailed guidance. apologies for the delay.

I have made the requested changes and updated the pull request. Please review and let me know if there are any further modifications needed.

[benkoshy]

thx @YutoYasunaga

I will review this next week: by the 2023-09-21.

[benkoshy]

Thank you for your patience. It looks good to me (even though I don't understand the language 😂 ). I have had a closer look at tested it out on my own repo:

The only issue now is working out why the CI is failing.

I will try to have a look by tomorrow.

[ddnexus]

@benkoshy It's missing the new file in the manifest. You can run the manifest:update task and commit.

Which is another point missed in the doc 🤷

[benkoshy]

@YutoYasunaga if you run the following command:

rake manifest:generate

and then confirm it with:

rake manifest:check

You can then add another commit and the CI will pass. Or you can cherry pick this commit: YutoYasunaga@68ae38b

And I think that will be all that is required.

[YutoYasunaga]

Thank for your help.

I pushed it already.

[benkoshy]

Rubocop is complaining. You can cherry-pick: ff4cd69

[YutoYasunaga]

@benkoshy Thank you. I have done it.

[ddnexus]

Thank you @YutoYasunaga @benkoshy