Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disclaimer on state modified behavior change #6357

Merged
merged 10 commits into from
Oct 25, 2024
Merged

Disclaimer on state modified behavior change #6357

merged 10 commits into from
Oct 25, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Oct 24, 2024 •
edited by github-actions bot
Loading

What are you changing in this pull request and why?

Closes #6247

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@matthewshaver matthewshaver requested a review from a team as a code owner October 24, 2024 14:52
@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 25, 2024 7:21pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address and removed Docs team Authored by the Docs team @dbt Labs labels Oct 24, 2024
@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Oct 24, 2024
@matthewshaver matthewshaver changed the title Disclaimer on statem modified behavior change Disclaimer on state modified behavior change Oct 24, 2024
nataliefiann
nataliefiann approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @matthewshaver

Apologies for the late reply. I reviewed this yesterday and forgot to approve.
I've approved this now for you.

Kind Regards
Natalie

runleonarun
runleonarun reviewed Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also should add reusable for the two notes to keep them in sync.

website/docs/reference/global-configs/behavior-changes.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs/behavior-changes.md Outdated Show resolved Hide resolved
@runleonarun runleonarun merged commit cb69cf6 into current Oct 25, 2024
13 checks passed
@runleonarun runleonarun deleted the state-comparison branch October 25, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun left review comments

@nataliefiann nataliefiann nataliefiann approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
4 participants
@matthewshaver @runleonarun @nataliefiann @mirnawong1