Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new spec to references pages #6190

Merged

Conversation

mirnawong1
Copy link
Contributor

this pr adds the new snapshot yaml spec to all the snapshot-related pages under 'references'. it updaes the following:

  • snapshot configs page
  • snapshot properties page
  • configs and properties page
  • post and pre hook page
  • resource configs for snapshots (10 pages, such as snapshot-name, updated_at key, unique_key, etc.)

this pr should merge into the main add/new-snapshot-spec-main branch

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 1, 2024 13:20
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 3, 2024 5:19pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person labels Oct 1, 2024
website/docs/reference/configs-and-properties.md Outdated Show resolved Hide resolved
website/docs/reference/snapshot-configs.md Outdated Show resolved Hide resolved
website/docs/reference/snapshot-configs.md Outdated Show resolved Hide resolved
Comment on lines +31 to 39
1. Using a [`config` property](/reference/resource-properties/config) in a `.yml` file in the `models/`, `snapshots/`, `seeds/`, `analyses`, or `tests/` directory
2. From the [`dbt_project.yml` file](dbt_project.yml), under the corresponding resource key (`models:`, `snapshots:`, `tests:`, etc)
</VersionBlock>

<VersionBlock lastVersion="1.8">

1. Using a [`config()` Jinja macro](/reference/dbt-jinja-functions/config) within a `model`, `snapshot`, or `test` SQL file
2. Using a [`config` property](/reference/resource-properties/config) in a `.yml` file
2. Using a [`config` property](/reference/resource-properties/config) in a `.yml` file in the `models/`, `snapshots/`, `seeds/`, `analyses/`, or `tests/` directory.
3. From the [`dbt_project.yml` file](dbt_project.yml), under the corresponding resource key (`models:`, `snapshots:`, `tests:`, etc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish for a later update down the road:

  • it would be awesome if we didn't need to explicitly list out the relevant resource types

Maybe there's a way we could instead could link to some list of the relevant resource types that support the config property within different file types? Maybe a new section here?

I think we should table this and open up a nice-to-have issue to consider later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

website/docs/reference/resource-configs/check_cols.md Outdated Show resolved Hide resolved
website/docs/reference/resource-configs/snapshot_name.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this page existed until this week!

We should consider an action item for later if we'd want to keep this page or retire it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now I see some other pages that link here: using a link to /reference/resource-configs/snapshot_name.

Still might be worth a 2nd look later since I don't think we have similar model_name, seed_name, etc. pages.

website/docs/reference/snapshot-configs.md Outdated Show resolved Hide resolved
website/docs/reference/snapshot-configs.md Outdated Show resolved Hide resolved
website/docs/reference/snapshot-configs.md Outdated Show resolved Hide resolved
website/docs/reference/snapshot-configs.md Outdated Show resolved Hide resolved
website/docs/reference/snapshot-configs.md Outdated Show resolved Hide resolved
@mirnawong1 mirnawong1 merged commit 8b5bd3b into add/new-snapshot-spec-main Oct 3, 2024
3 of 4 checks passed
@mirnawong1 mirnawong1 deleted the add/new-snapshot-spec-reference branch October 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants