-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply "Initial refactoring of incremental materialization" #1123
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Drew Goya.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Drew Goya.
|
…s/dbt-core#5359). Now it uses `adapter.get_incremental_strategy_macro` instead of dbt-spark's `dbt_spark_get_incremental_sql` macro to dispatch the incremental strategy macro. Add tests that check for the new error string
729385d
to
f3cb955
Compare
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @hiloboy0119 |
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @hiloboy0119 |
Problem
dbt-spark uses the old method of applying incremental materialization macros.
This PR is a draft because I also dropped support for python 3.8 to get tests to pass. I will remove that commit when pull/1121 is merged
Solution
Applies "Initial refactoring of incremental materialization" (dbt-labs/dbt-core#5359).
Now it uses adapter.get_incremental_strategy_macro instead of dbt-spark's dbt_spark_get_incremental_sql macro to dispatch the incremental strategy macro.
Checklist