Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private_key_path from _conection_keys #950

Merged
merged 64 commits into from
Mar 25, 2024
Merged

Remove private_key_path from _conection_keys #950

merged 64 commits into from
Mar 25, 2024

Conversation

McKnight-42
Copy link
Contributor

resolves #949
docs dbt-labs/docs.getdbt.com/#

Problem

the field private_key_path could have a argument to be a qausi secret level like field that possibly should be removed from debug and being called in jinja

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Mar 22, 2024
@cla-bot cla-bot bot added the cla:yes label Mar 22, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@McKnight-42 McKnight-42 changed the title Mcknight/949 Remove private_key_path from _conection_keys Mar 22, 2024
@McKnight-42 McKnight-42 marked this pull request as ready for review March 22, 2024 18:52
@will-sargent-dbtlabs
Copy link

Hi Team! If we are able to get this reviewed and implemented, I believe this issue is a blocking issue (or contributing) for several major customers from using parse caching for jobs, so high-value win potential. Thanks @McKnight-42 for getting this edit in the pipeline!

@McKnight-42 McKnight-42 added backport 1.6.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch labels Mar 25, 2024
@McKnight-42 McKnight-42 merged commit 1b5c165 into main Mar 25, 2024
35 checks passed
@McKnight-42 McKnight-42 deleted the mcknight/949 branch March 25, 2024 17:32
@McKnight-42 McKnight-42 added backport 1.6.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch and removed backport 1.6.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch labels Mar 25, 2024
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
* update RELEASE_BRANCH env

* remove private_key_path from _connections

* add changelog

(cherry picked from commit 1b5c165)
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
* update RELEASE_BRANCH env

* remove private_key_path from _connections

* add changelog

(cherry picked from commit 1b5c165)
@will-sargent-dbtlabs
Copy link

@McKnight-42 How long before this will be reflected in mt via dbt debug for versionless?

@McKnight-42
Copy link
Contributor Author

@will-sargent-dbtlabs I don't have a exact timeframe I think we are doing some releases tomorrow, so we will create the bundles and stuff then and usually takes a few days or so to populate throughout cloud once its all out so sometime mid next week possibly? similar timeframe for 1.7 and 1.6 adapters once the backports are merged

McKnight-42 added a commit that referenced this pull request Mar 26, 2024
* update RELEASE_BRANCH env

* remove private_key_path from _connections

* add changelog

(cherry picked from commit 1b5c165)

Co-authored-by: Matthew McKnight <[email protected]>
McKnight-42 added a commit that referenced this pull request Mar 26, 2024
* update RELEASE_BRANCH env

* remove private_key_path from _connections

* add changelog

(cherry picked from commit 1b5c165)

Co-authored-by: Matthew McKnight <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Remove private_key_path from SnowflakeCredentials._connection_keys
3 participants