Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break apart CI workflows into composite actions #841

Closed
wants to merge 33 commits into from

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Nov 22, 2023

Edit: This PR is a pilot and will be broken down into workflow-specific PRs.

Problem

There are several places where the same steps are repeated across workflows. Additionally, while migrating from setup.py to pyproject.toml, there were some scenarios where migrating would be difficult because updating dependent centralized actions would adversely impact other repos.

Solution

If the workflows are broken apart into composite actions, then those actions could be reused across workflows. Additionally this may reduce the need for certain centralized actions.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Nov 22, 2023
@cla-bot cla-bot bot added the cla:yes label Nov 22, 2023
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare
Copy link
Contributor Author

This will happen as part of migrating to dbt-adapters

@mikealfare mikealfare closed this Jan 16, 2024
@mikealfare mikealfare deleted the devops/composite-actions branch January 16, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant