Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test against 1.7.latest release branch and fix semve #797

Merged
merged 42 commits into from
Oct 9, 2023

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Oct 9, 2023

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Currently nightly release tests fail since core does not view the supplied adapter version as valid semver:
dbt.exceptions.SemverError: "1.5.6.dev10092023" is not a valid semantic version.
This change would have "dev" be a build tag instead of a patch version, so the new version be: 1.5.6+dev10092023
resolves #

Solution

reassign part of semvar to tag to be able to read it properly

dbt-snowflake version of this fix dbt-labs/dbt-bigquery#961

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Oct 9, 2023
@McKnight-42 McKnight-42 self-assigned this Oct 9, 2023
@McKnight-42 McKnight-42 requested a review from a team as a code owner October 9, 2023 20:43
@cla-bot cla-bot bot added the cla:yes label Oct 9, 2023
@McKnight-42
Copy link
Contributor Author

@McKnight-42 McKnight-42 temporarily deployed to PypiTest October 9, 2023 21:33 — with GitHub Actions Inactive
@colin-rogers-dbt colin-rogers-dbt merged commit 1bbbb96 into main Oct 9, 2023
73 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the fixNightlyRelease branch October 9, 2023 23:13
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
* update RELEASE_BRANCH env

* test semver in 1.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants