ADAP-728: Fix "On Configuration Change" config #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
mikealfare
changed the title
1 task
mikealfare
commented
Jul 27, 2023
mikealfare
commented
Jul 27, 2023
dbt/include/snowflake/macros/materializations/dynamic_table/ddl.sql
Outdated
Show resolved
Hide resolved
mikealfare
commented
Jul 27, 2023
mikealfare
commented
Jul 27, 2023
mikealfare
commented
Jul 27, 2023
mikealfare
commented
Jul 27, 2023
mikealfare
commented
Jul 27, 2023
mikealfare
commented
Jul 27, 2023
mikealfare
commented
Jul 27, 2023
tests/functional/adapter/dynamic_table_tests/test_dynamic_tables_changes.py
Outdated
Show resolved
Hide resolved
colin-rogers-dbt
approved these changes
Jul 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
* add alter scenario for dynamic tables * remove pytest skip statements on change tests * update target lag tests * fix target_lag in create dynamic table statement * fixed name changes during model production * clean up dynamic table changeset * update target lag input options * changie * remove unnecessary asserts * skip F401 on raising objects in __init__.py (cherry picked from commit 02935f7)
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Jul 31, 2023
* add alter scenario for dynamic tables * remove pytest skip statements on change tests * update target lag tests * fix target_lag in create dynamic table statement * fixed name changes during model production * clean up dynamic table changeset * update target lag input options * changie * remove unnecessary asserts * skip F401 on raising objects in __init__.py (cherry picked from commit 02935f7) Co-authored-by: Mike Alfare <[email protected]>
philippe-boyd-maxa
pushed a commit
to maxa-ai/dbt-snowflake
that referenced
this pull request
Nov 27, 2023
* add alter scenario for dynamic tables * remove pytest skip statements on change tests * update target lag tests * fix target_lag in create dynamic table statement * fixed name changes during model production * clean up dynamic table changeset * update target lag input options * changie * remove unnecessary asserts * skip F401 on raising objects in __init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The beta implementation was completely bypassing the
on_configuration_changesetting, which could potentially result in removing an object which the end user did not intend to remove.Solution
Implement
on_configuration_changecorrectly and un-comment relevant tests.Checklist