Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit test mocks to handle the new query_id field #1238

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Update unit test mocks to handle the new query_id field #1238

merged 1 commit into from
Nov 8, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We added query_id as a new field on the AdapterResponse event. This needs to be a string to pass validation.

Solution

Mock the sfqid method to return a string literal instead of the mocked object it gets via MagicMock.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Nov 8, 2024
@mikealfare mikealfare requested a review from a team as a code owner November 8, 2024 05:35
@cla-bot cla-bot bot added the cla:yes label Nov 8, 2024
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Nov 8, 2024
@mikealfare mikealfare changed the base branch from main to 1.8.latest November 8, 2024 05:35
@mikealfare
Copy link
Contributor Author

Kick the CI

@mikealfare mikealfare closed this Nov 8, 2024
@mikealfare mikealfare reopened this Nov 8, 2024
@mikealfare mikealfare merged commit 243ea4f into 1.8.latest Nov 8, 2024
32 of 34 checks passed
@mikealfare mikealfare deleted the fix-query-id-test-mocks branch November 8, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @colin-rogers-dbt