Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add url. #1222

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add url. #1222

merged 1 commit into from
Oct 22, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Oct 22, 2024 •
edited
Loading

resolves 209

Problem

The docs here didn't exist before. We left a placeholder for the relevant docs page.

Solution

Now it exists. Point it!

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Oct 22, 2024
@VersusFacit VersusFacit requested a review from a team as a code owner October 22, 2024 15:57
@cla-bot cla-bot bot added the cla:yes label Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Oct 22, 2024
@VersusFacit VersusFacit merged commit ea33cbe into main Oct 22, 2024
49 of 51 checks passed
@VersusFacit VersusFacit deleted the ADAP-209/update_iceberg_docs_note branch October 22, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees

@VersusFacit VersusFacit

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VersusFacit @mikealfare