Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared empty flag tests #1104

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Use shared empty flag tests #1104

merged 2 commits into from
Jul 3, 2024

Conversation

mikealfare
Copy link
Contributor

resolves #1033

Problem

The local tests have been implemented in dbt-tests-adapter and these can get out of sync.

Solution

Swap out local test implementation to use the shared tests.

Implementation

  1. Merge this PR demonstrating that these tests work
  2. Move the bulk of this PR into dbt-tests-adapter
  3. Create a final PR that removes most of this and uses the dbt-tests-adapter tests (we`re here)

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jul 3, 2024
@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare mikealfare marked this pull request as ready for review July 3, 2024 20:09
@mikealfare mikealfare requested a review from a team as a code owner July 3, 2024 20:09
@cla-bot cla-bot bot added the cla:yes label Jul 3, 2024
@mikealfare mikealfare enabled auto-merge (squash) July 3, 2024 21:52
@mikealfare mikealfare merged commit 8ae3ec8 into main Jul 3, 2024
22 checks passed
@mikealfare mikealfare deleted the use-shared-empty-flag-tests branch July 3, 2024 21:53
Copy link
Contributor

The backport to 1.8.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-1104-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ae3ec89f7bc829cfa9351100905e13bc42542ac
# Push it to GitHub
git push --set-upstream origin backport-1104-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest

Then, create a pull request where the base branch is 1.8.latest and the compare/head branch is backport-1104-to-1.8.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] --empty doesn't work when using get_columns_in_relation
2 participants