-
Notifications
You must be signed in to change notification settings - Fork 175
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Backport 1.7.latest] Acknowledge
send_anonymous_usage_stats
settin…
…g for python models (#948) * Acknowledge `send_anonymous_usage_stats` setting for python models (#933) * add draft integration test demonstrating the issue * changie * condition on the send_anonymous_usage_stats setting when building a python model (cherry picked from commit ad7ea4d) * update how to turn send_anonymous_usage_stats on and off for 1.7 in the test fixtures --------- Co-authored-by: Mike Alfare <[email protected]> Co-authored-by: Mike Alfare <[email protected]>
- Loading branch information
1 parent
bdc975e
commit 7cb4059
Showing
3 changed files
with
54 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Fixes | ||
body: Acknowledge `send_anonymous_usage_stats` setting for python models | ||
time: 2024-03-18T20:36:35.396323-04:00 | ||
custom: | ||
Author: mikealfare | ||
Issue: "830" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
from dbt.tests.util import run_dbt_and_capture | ||
import pytest | ||
|
||
|
||
ANONYMOUS_USAGE_MESSAGE = """ | ||
sys._xoptions['snowflake_partner_attribution'].append("dbtLabs_dbtPython") | ||
""".strip() | ||
|
||
|
||
MY_PYTHON_MODEL = """ | ||
import pandas | ||
def model(dbt, session): | ||
dbt.config(materialized='table') | ||
data = [[1,2]] * 10 | ||
return pandas.DataFrame(data, columns=['test', 'test2']) | ||
""" | ||
|
||
|
||
class AnonymousUsageStatsBase: | ||
@pytest.fixture(scope="class") | ||
def models(self): | ||
return {"my_python_model.py": MY_PYTHON_MODEL} | ||
|
||
|
||
class TestAnonymousUsageStatsOn(AnonymousUsageStatsBase): | ||
@pytest.fixture(scope="class") | ||
def profiles_config_update(self): | ||
return {"config": {"send_anonymous_usage_stats": True}} | ||
|
||
def test_stats_get_sent(self, project): | ||
_, logs = run_dbt_and_capture(["--debug", "run"]) | ||
assert ANONYMOUS_USAGE_MESSAGE in logs | ||
|
||
|
||
class TestAnonymousUsageStatsOff(AnonymousUsageStatsBase): | ||
@pytest.fixture(scope="class") | ||
def profiles_config_update(self): | ||
return {"config": {"send_anonymous_usage_stats": False}} | ||
|
||
def test_stats_do_not_get_sent(self, project): | ||
_, logs = run_dbt_and_capture(["--debug", "run"]) | ||
assert ANONYMOUS_USAGE_MESSAGE not in logs |