Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: Remove unused stub function #1393

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

nit: Remove unused stub function #1393

wants to merge 5 commits into from

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented Nov 4, 2024 •
edited
Loading

resolves N/A

Problem

The _stub_relation function is not used anywhere. The increase in unused code increases the cognitive load on the developer.

Solution

Delete the _stub_relation function, which is not used anywhere.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Nov 4, 2024
@syou6162 syou6162 changed the title Fix/remove unused code nit: Remove unused stub function Nov 4, 2024
@syou6162 syou6162 marked this pull request as ready for review November 4, 2024 13:05
@syou6162 syou6162 requested a review from a team as a code owner November 4, 2024 13:05
@syou6162 syou6162 marked this pull request as draft November 4, 2024 13:12
@syou6162 syou6162 marked this pull request as ready for review November 4, 2024 13:12
@syou6162
Copy link
Contributor Author

syou6162 commented Nov 4, 2024

The CI for Check Changelog Entry has failed, but since it only deletes unused code, I have decided that the ChangeLog can be skipped.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Nov 9, 2024
@mikealfare mikealfare self-assigned this Nov 9, 2024
@mikealfare
Copy link
Contributor

@syou6162 Thanks for the "maintenance" PR. Not everyone is keen to submit those, but they're just as valuable to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syou6162 @mikealfare