Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _json_from_json patch #1061

Merged
merged 10 commits into from
Feb 20, 2024
Merged

remove _json_from_json patch #1061

merged 10 commits into from
Feb 20, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

remove _json_from_json patch

addresses: #1055

docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt self-assigned this Dec 19, 2023
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner December 19, 2023 23:38
@cla-bot cla-bot bot added the cla:yes label Dec 20, 2023
@mikealfare mikealfare marked this pull request as draft January 30, 2024 21:30
@mikealfare
Copy link
Contributor

@colin-rogers-dbt I converted this to a draft while we wait for the fix to go out in bigquery.

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review February 8, 2024 00:11
@mikealfare
Copy link
Contributor

@colin-rogers-dbt Does this need to be backported? If so, please add it to the release ticket (and apply the backport labels of course).

@dbeatty10
Copy link
Contributor

This looks like it will fix #1101 also.

We'd just want to add the following test case also:

dbt show --inline 'select parse_json(null)'

@colin-rogers-dbt colin-rogers-dbt merged commit 6b48ec8 into main Feb 20, 2024
15 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the removeJsonOverride branch February 20, 2024 18:54
Copy link
Contributor

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-1061-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b48ec89c1d10124dd31ebaf2e8c2f5aae4ec68a
# Push it to GitHub
git push --set-upstream origin backport-1061-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-1061-to-1.7.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants