Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary and foreign key constraints are not enforced in BigQuery #1019

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Primary and foreign key constraints are not enforced in BigQuery #1019

merged 6 commits into from
Jan 23, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Nov 11, 2023 •
edited
Loading

resolves #1018
dbt-labs/docs.getdbt.com#4419

Problem

The source code says here that primary_key and foreign_key are enforced.

But as noted in dbt-labs/docs.getdbt.com#4419, they are supported, but not enforced.

Solution

Update the CONSTRAINT_SUPPORT to reflect what the BigQuery docs say here and here.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR is relying on pre-existing tests for this feature
  • This PR has no interface changes
  • This PR has an associated docs update in docs.getdbt.com #4419

@dbeatty10 dbeatty10 added the Skip Changelog Skips GHA to check for changelog file label Nov 11, 2023
@cla-bot cla-bot bot added the cla:yes label Nov 11, 2023
@dbeatty10 dbeatty10 removed the Skip Changelog Skips GHA to check for changelog file label Nov 16, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review November 16, 2023 14:25
@dbeatty10 dbeatty10 requested a review from a team as a code owner November 16, 2023 14:25
@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Nov 16, 2023
@colin-rogers-dbt colin-rogers-dbt merged commit 70b7445 into main Jan 23, 2024
15 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the dbeatty/primary-foreign-keys-not-enforced branch January 23, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-1028] [Bug] primary and foreign keys are supported but not enforced
4 participants
@dbeatty10 @colin-rogers-dbt @mikealfare @McKnight-42