Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avatarURL does not exists #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

xalakox
Copy link

@xalakox xalakox commented Jul 19, 2018

image

@davidyaha
Copy link
Owner

Hey @xalakox! Thanks for the PR!

This whole workshop needs quite an extensive update actually...
Also take a look at the commits and see that I've used commits as workshop steps so that you could always compare two steps and see what was the changes during those steps... This makes for a cool feature when creating a tutorial, although it is much harder to update steps when they are obsolete..
I actually don't have a good solution for that but the only way to change a commit is to checkout the commit before it, update those changes and re-create this commit, then rebase the rest of the commit tree.
I would gladly accept any PRs that stick to this pattern, or suggest a better solution that holds the same ideas in place.

If you don't want/or have the time to make that PR though, I hope this repo was still useful for you to some extent.
Have an awesome day!

@davidyaha
Copy link
Owner

Also, a friend and a great developer (@pradel) has an updated version that has steps split to directories so it's easier to update - https://github.com/pradel/graphql-workshop

Hope this helps as well 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants