Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2D uncertainties and intrinsic variance exercises #29

Merged
merged 6 commits into from
Jul 26, 2017

Conversation

jobovy
Copy link
Collaborator

@jobovy jobovy commented Jun 2, 2017

This PR fixes the code for the exercises with uncertainties in x and y and updates those plots (see #18).

I also worked out how to fix the intrinsic variance objective function (which is also wrong in the paper currently I think). I think it should be

ln L = -0.5 \sum ( Delta_i^2 / [Sigma_i^2 + V] + ln[ Sigma_i^2 + V] + ln[ 1+m^2] )

so there's an additional term again. I think this agrees with @dfm's solution here (only saw this after I worked mine out, so independent).

I think I've coded that likelihood up correctly, but am getting strange results (see ex16.pdf and ex17.pdf in the updated files). @dfm, have you tried your code on the HBL data?

P.S.: the data was missing in the src/ directory, so I have also added files with the mock data, so the code should run easily now.

This PR should probably only be merged once @davidwhogg also updates the document.

@jobovy jobovy requested review from dfm and davidwhogg June 2, 2017 21:53
@davidwhogg
Copy link
Owner

@jobovy Do you want to take a shot at updating the words and equations in the relevant part of the text, or are you suggesting / requiring that I do that? :)

@jobovy
Copy link
Collaborator Author

jobovy commented Jun 4, 2017

I was suggesting you should do it 😄

@davidwhogg
Copy link
Owner

Okay I made text updates with which I am not perfectly happy. I am merging this because we have something conceivable now.

@davidwhogg davidwhogg merged commit 2682db4 into master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants