Update 2D uncertainties and intrinsic variance exercises #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the code for the exercises with uncertainties in x and y and updates those plots (see #18).
I also worked out how to fix the intrinsic variance objective function (which is also wrong in the paper currently I think). I think it should be
so there's an additional term again. I think this agrees with @dfm's solution here (only saw this after I worked mine out, so independent).
I think I've coded that likelihood up correctly, but am getting strange results (see ex16.pdf and ex17.pdf in the updated files). @dfm, have you tried your code on the HBL data?
P.S.: the data was missing in the
src/
directory, so I have also added files with the mock data, so the code should run easily now.This PR should probably only be merged once @davidwhogg also updates the document.