-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multilineProperty method to test_node #76
Add multilineProperty method to test_node #76
Conversation
Thanks for your contribution! In general I'm happy with it, but I'm not a big fan of boolean flags in public APIs. I can think of two reasonable alternatives:
I'm leaning towards the first option to avoid assumptions and unexpected errors, but having the library do the "right thing" for the user is also appealing. What do you think? |
I like option 1, too. I'll change the PR this evening. |
@davidparsson i've now added the textContentProperty - hope the new api is better. |
Thanks, I like this! I'll consider if the names are good enough or if anything should be renamed, but I think I can merge this in its current form. Thank you for your contribution! |
To be honest - I'm not 100% convinced that the method name is easy to understand :) but as of now I don't have any better name.... |
Perhaps |
That sounds good. I'll try to update the PR asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! 🤩
@sebastian-sauer, this is now released in v5.1.0. Thanks! |
Some tools allow the property to have a textContent and not use the value attribute.
See https://github.com/testmoapp/junitxml?tab=readme-ov-file#properties-for-suites-and-cases for examples.