add property to testcase #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for your contribution. However, I can't accept it in its current state since tests are failing. |
|
Ok, I should fix the error... try now |
davidparsson
requested changes
Oct 9, 2023
There was a problem hiding this comment.
The changes look reasonable, but new tests are missing. I did not look close enough to spot that when the tests were failing.
I would expect both spec/test_case_spec.coffee and spec/e2e_spec.coffee to be updated.
Also I'm not over excited over the syntactical (quote) changes that no longer matches the rest of the project.
|
Ok, I restored the syntactical quote changes and I have update tests: Hope everything is fine this time :) |
davidparsson
approved these changes
Oct 10, 2023
|
Thank you! I and @alecmestroni think it could be useful to many :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I create this fork to add property element to testcase.
I saw there is this #49 issue open, I hope you want to approve it.