Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL support #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OpenSSL support #213

wants to merge 1 commit into from

Conversation

xest
Copy link

@xest xest commented Feb 27, 2017

Add ONION_USE_OPENSSL option to use OpenSSL instead of GnuTLS and GCrypt(default: false).
Tested on Ubuntu 16.10, OpenSSL 1.0.2g.

@davidmoreno
Copy link
Owner

Hi! Thanks a lot for the patch, but although it makes the trick, I dont like too much that it actually do a half wrapper for openssl using gnutls functions (particularly the use of the headers with the defines). It hides whats really going on.

I would prefer a openssl.c and a gnutls.c that implement the basic functions (basically whats on the defines and the extra headers), and make https.c call the proper implementation.

@xest
Copy link
Author

xest commented Feb 28, 2017

Hi! I know what you said.
Actually I added random-openssl.c and https-openssl.c at first, but the differences between GnuTLS version and OpenSSL version were not too much.
But if you don't like this way, I'll do it again a few weeks after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants