Fix panic when determining cluster domain. #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The tests would always test version 1.0.0, not the current version. - The test would always fail some tests on first run. Second attempt succeeded due to cached results of the first test. - Tests were divided into separate package (and hence separate executables) and ran in parallel using the same namespace. This caused lots of intermittent failures. - Test cleanup happened at the wrong time. It's truly amazing that the tests did succeed at the second run. Signed-off-by: Thomas Hallgren <[email protected]>
Closed telepresenceio/telepresence#3418 Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/fix-panic
branch
from
4d51429 to
d588a15
Compare
Updates all dependencies using `go get -u ./...`. Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/fix-panic
branch
from
d588a15 to
6955feb
Compare
thallgren
force-pushed
the
thallgren/fix-panic
branch
15 times, most recently
from
17ce730 to
f1efc5f
Compare
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/fix-panic
branch
from
f1efc5f to
49b30c4
Compare
LanceEa
approved these changes
Dec 5, 2023
| @@ -609,6 +608,8 @@ func TestWatchErrorSendingSnapshot(t *testing.T) { | |||
| cancel() | |||
| t.Fatal("Timed out waiting for report to complete.") | |||
| } | |||
| ts.Close() | |||
There was a problem hiding this comment.
Since there are t.Fatal calls in the select case wont this fail to be called now that it is no longer a defer?
| env: | ||
| A8R_AGENT_VERSION: ${{ steps.build.outputs.version }} | ||
| AMBASSADOR_AGENT_DOCKER_IMAGE: localhost:5000/ambassador-agent:${{ steps.build.outputs.version }} | ||
| KAT_SERVER_DOCKER_IMAGE: docker.io/datawiredev/kat-server:3.0.1-0.20220817135951-2cb28ef4f415 |
There was a problem hiding this comment.
random thought:
I'm not too familiar with the Agent code base beyond knowing it was historically in emissary-ingress repo and just scrapes Edgissary for data and forwards it on to Ambassador Cloud. But, I was surprised to see references to the kat-server so I will take it as a mental note to investigate this further during cooldown.
Signed-off-by: Thomas Hallgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also upgrades all dependencies and fixes broken integration tests.