Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.0.0 #48

Merged
merged 20 commits into from
Nov 21, 2023
Merged

Release 6.0.0 #48

merged 20 commits into from
Nov 21, 2023

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Nov 21, 2023

What's Changed

New Contributors

Full Changelog: v5.1.0...v6.0.0

thinkh and others added 20 commits September 29, 2023 10:55
### Developer Checklist (Definition of Done)

**Issue**

- [ ] All acceptance criteria from the issue are met
- [ ] Tested in latest Chrome/Firefox

**UI/UX/Vis**

- [ ] Requires UI/UX/Vis review
  - [ ] Reviewer(s) are notified (_tag assignees_)
  - [ ] Review has occurred (_link to notes_)
  - [ ] Feedback is included in this PR
  - [ ] Reviewer(s) approve of concept and design

**Code**

- [ ] Branch is up-to-date with the branch to be merged with, i.e.,
develop
- [ ] Code is cleaned up and formatted
- [ ] Unit tests are written (frontend/backend if applicable)
- [ ] Integration tests are written (if applicable)

**PR**

- [ ] Descriptive title for this pull request is provided (will be used
for release notes later)
- [ ] Reviewer and assignees are defined
- [ ] Add type label (e.g., *bug*, *feature*) to this pull request
- [ ] Add release label (e.g., `release: minor`) to this PR following
[semver](https://semver.org/)
- [ ] The PR is connected to the corresponding issue (via `Closes #...`)
- [ ] [Summary of changes](#summary-of-changes) is written


### Summary of changes

- Playwright and Jest use the same pattern, such that Jest picks up
playwright tests. This PR adds the flags to ignore all playwright
folders.

### Screenshots


### Additional notes for the reviewer(s)

-  
Thanks for creating this pull request 🤗
### Developer Checklist (Definition of Done)

**Issue**

- [ ] All acceptance criteria from the issue are met
- [ ] Tested in latest Chrome/Firefox

**UI/UX/Vis**

- [ ] Requires UI/UX/Vis review
  - [ ] Reviewer(s) are notified (_tag assignees_)
  - [ ] Review has occurred (_link to notes_)
  - [ ] Feedback is included in this PR
  - [ ] Reviewer(s) approve of concept and design

**Code**

- [ ] Branch is up-to-date with the branch to be merged with, i.e.,
develop
- [ ] Code is cleaned up and formatted
- [ ] Unit tests are written (frontend/backend if applicable)
- [ ] Integration tests are written (if applicable)

**PR**

- [ ] Descriptive title for this pull request is provided (will be used
for release notes later)
- [ ] Reviewer and assignees are defined
- [ ] Add type label (e.g., *bug*, *feature*) to this pull request
- [ ] Add release label (e.g., `release: minor`) to this PR following
[semver](https://semver.org/)
- [ ] The PR is connected to the corresponding issue (via `Closes #...`)
- [ ] [Summary of changes](#summary-of-changes) is written


### Summary of changes
- pin @swc/core version to 1.3.95 as there was an webpack error
appearing in bioinsight on production builds
- `Uncaught TypeError: Cannot read properties of undefined (reading
'random')
    at jstat.js:113:25`

### Screenshots
Fixed error in bioinsight:

![image](https://github.com/datavisyn/visyn_scripts/assets/101096478/b2696134-9b63-4b73-8cb4-dbe1a27eb63f)
**Migration guide for Node 20 and no_dist:** 

First, create a `no_dist` branch and do the following in the
package.json:
* Replace all of our dependencies with the `#no_dist` branch
* Update the exports/main/types fields. This has to be done according
what is already exported, but if no exports field exists, you the
following:
```json
  "main": "src/index.ts",
  "types": "src/index.ts",
  "exports": {
    ".": {
      "types": [
        "./dist/index.d.ts",
        "./src/index.ts"
      ],
      "import": [
        "./dist/index.js",
        "./src/index.ts"
      ],
      "default": [
        "./dist/index.js",
        "./src/index.ts"
      ]
    },
    "./phovea_registry": [
      "./dist/phovea_registry.js",
      "./src/phovea_registry.ts"
    ],
    "./dist/phovea_registry": [
      "./dist/phovea_registry.js",
      "./src/phovea_registry.ts"
    ],
    "./dist/scss/*": [
      "./dist/scss/*",
      "./src/scss/*"
    ],
    "./package.json": "./package.json"
  },
```
* Switch to Node 20 using `nvm use 20.9` (this should be the default!
Uninstall all other node versions using nvm uninstall ...)
* Then install and test using `rm -rf yarn.lock node_modules && yarn &&
yarn run all && yarn webpack:prod && yarn start dev_server_only=true`
* In the end, make sure to create a PR and link it in the repo sheet
(see Node20 and no_dist column)

If you encounter any issues, please report them.
@thinkh thinkh self-assigned this Nov 21, 2023
@thinkh thinkh requested a review from a team as a code owner November 21, 2023 10:28
@thinkh thinkh added the release: major PR merge results in a new major version label Nov 21, 2023
Copy link
Contributor

@dv-usama-ansari dv-usama-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks good to me 👍

@thinkh thinkh merged commit ef98939 into main Nov 21, 2023
1 check passed
@thinkh thinkh deleted the release-6.0.0 branch November 21, 2023 10:32
@thinkh thinkh restored the release-6.0.0 branch November 21, 2023 10:33
@thinkh thinkh deleted the release-6.0.0 branch November 21, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: major PR merge results in a new major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants