Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace categoricalColors with categoricalColors10 #594

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Oct 24, 2024

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Replace the deprecated categoricalColors with categoricalColors10 in scatter plot and violin plot

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@thinkh thinkh added type: bug Something isn't working vis-type: scatter labels Oct 24, 2024
@thinkh thinkh self-assigned this Oct 24, 2024
@thinkh thinkh requested a review from a team as a code owner October 24, 2024 09:38
@thinkh thinkh merged commit ae6670f into develop Oct 24, 2024
9 of 11 checks passed
@thinkh thinkh deleted the thinkh/use-categoricalColors10 branch October 24, 2024 11:20
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working vis-type: scatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants