Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify and improve missing column warning message #593

Merged
merged 59 commits into from
Oct 24, 2024

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Oct 23, 2024

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • create error and warning component
  • unify missing column warning message
  • improved text of missing column message

Screenshots

Warning message if columns are missing:

image

Error message in bar chart:

image

Additional notes for the reviewer(s)

Please review the style and content of the messages. The title in the error and warning message is optional.


Thanks for creating this pull request 🤗

dv-usama-ansari and others added 30 commits October 17, 2024 11:11
src/locales/en/visyn.json Outdated Show resolved Hide resolved
src/locales/en/visyn.json Show resolved Hide resolved
src/locales/en/visyn.json Outdated Show resolved Hide resolved
@thinkh thinkh force-pushed the thinkh/unified-warning-message branch from cb767b9 to 1730dcb Compare October 24, 2024 09:55
@thinkh thinkh changed the base branch from ua/563-bar-chart-follow-up-bugs to develop October 24, 2024 11:04
@thinkh thinkh dismissed dvdanielamoitzi’s stale review October 24, 2024 11:04

The base branch was changed.

@thinkh thinkh merged commit 6d47a3a into develop Oct 24, 2024
3 of 4 checks passed
@thinkh thinkh deleted the thinkh/unified-warning-message branch October 24, 2024 11:21
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants