-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: unify and improve missing column warning message #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ced resize observer
…datavisyn/visyn_core into ua/563-bar-chart-follow-up-bugs
thinkh
added
release: patch
PR merge results in a new patch version
type: refactor
Refactor the current implementation
vis-type: scatter
vis-type: bar
vis-type: hexbin
vis-type: sankey
vis-type: heatmap
vis-type: violin
vis-type: correlation
labels
Oct 23, 2024
dvdanielamoitzi
requested changes
Oct 24, 2024
dvdanielamoitzi
previously approved these changes
Oct 24, 2024
…o ua/563-bar-chart-follow-up-bugs
thinkh
force-pushed
the
thinkh/unified-warning-message
branch
from
October 24, 2024 09:55
cb767b9
to
1730dcb
Compare
thinkh
changed the base branch from
ua/563-bar-chart-follow-up-bugs
to
develop
October 24, 2024 11:04
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: patch
PR merge results in a new patch version
type: refactor
Refactor the current implementation
vis-type: bar
vis-type: correlation
vis-type: heatmap
vis-type: hexbin
vis-type: sankey
vis-type: scatter
vis-type: violin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Checklist (Definition of Done)
Issue
UI/UX/Vis
Code
PR
release: minor
) to this PR following semverCloses #...
)Summary of changes
Screenshots
Warning message if columns are missing:
Error message in bar chart:
Additional notes for the reviewer(s)
Please review the style and content of the messages. The title in the error and warning message is optional.
Thanks for creating this pull request 🤗