Draft projects musn't be publicly accessible #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiendmt
approved these changes
Sep 26, 2023
|
@bastiendmt raised interesting concerns about the way our tests are written and I'd like to spend some more time rewriting them. |
|
@bastiendmt thank you very much for the reviews @lutangar so far the goal is to have a usable tool. Secondly, we must respond to issues specific to Industry Map. Then we can focus on testing (and Kepler migration), so that would be November or something. Unless you tell me it's just an hour or it's an emergency. |
fix(project): forbid requesting a draft project fix(project): fix project guard
...fetching projects was returning a 500...
Co-authored-by: Bastien Dumont <[email protected]> Update apps/backend-e2e/src/e2e/auth.cy.ts Co-authored-by: Bastien Dumont <[email protected]> Update apps/backend-e2e/src/e2e/auth.cy.ts Co-authored-by: Bastien Dumont <[email protected]>
lutangar
force-pushed
the
draft-project-publicly-accessible
branch
from
84c7742
to
0525eb6
Compare
chore(ci): test chore(ci): fix credentials chore(ci): run background idomitc way chore(ci): specify container chore(ci): map to host chore(ci): setup users chore(ci): add & use wait-on chore(ci): run wait on sequentially chore(ci): run wait on sin server step chore(env): fix in ci chore(env): simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbid access to draft projects from any users except owner & admin.