Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected values in SingleRestrictionEstimatedRowCountTest #1523

Open
wants to merge 1 commit into
base: main-5.0
Choose a base branch
from

Conversation

k-rus
Copy link

@k-rus k-rus commented Jan 21, 2025

Fixes https://github.com/riptano/cndb/issues/12243

main-5.0 uses different default for memetable SAI structure than 5.0. This commits adjusts the expected row count values. Also removes assert on the total row count, since it varies in this branch for different column types.

This PR is likely to conflict with #1502 after the merge when rebased from main.

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

Fixes riptano/cndb#12243

main-5.0 uses different default for memetable SAI structure than 5.0.
This commits adjusts the expected row count values. Also removes assert
on the total row count, since it varies in this branch for different
column types.
@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1523 rejected by Butler


71 new test failure(s) in 1 builds
See build details here


Found 71 new test failures

Showing only first 15 new test failures

Test Explanation Branch history Upstream history
t.TestCqlshUnicode.test_unicode_identifier regression 🔴
o.a.c.d.c.CompactionControllerTest.testMemtable... regression 🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50 regression 🔴
...ersionTest.v4ConnectionCleansUpThreadLocalState regression 🔴
...d.t.QueriesTableTest.shouldExposeReadsAndWrites regression 🔴
...rtitionRestrictedQueryTest.testSAIWarnThreshold regression 🔴
...1, expectedHeaders=[Ljava.lang.String;@cb191ca] regression 🔴
..., expectedHeaders=[Ljava.lang.String;@792bbc74] regression 🔴
...eadSizeWarningTest.warnThresholdSinglePartition regression 🔴
....s.f.SnapshotTest.shouldTakeAndRestoreSnapshots regression 🔴
o.a.c.i.c.CompressionMetadataTest.testMemoryIsF... regression 🔴
...ntIrWithPreviewFuzzTest.concurrentIrWithPreview regression 🔴
o.a.c.t.SSTablePartitionsTest.testBackups regression 🔴
o.a.c.t.SSTablePartitionsTest.testCurrentTimestamp regression 🔴
o.a.c.t.SSTablePartitionsTest.testExcludedKeys regression 🔴

No known test failures found

@k-rus
Copy link
Author

k-rus commented Jan 24, 2025

#1502 was merged. @djatnieks should I cherry pick it into this PR?

@djatnieks
Copy link

#1502 was merged. @djatnieks should I cherry pick it into this PR?

Yes, I think that sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants