Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arrow-buffer requirement from 52 to 53 #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Update arrow-buffer requirement from 52 to 53

7d188a9
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Update arrow-buffer requirement from 52 to 53 #13

Update arrow-buffer requirement from 52 to 53
7d188a9
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Sep 4, 2024 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (1)

arrow-open-variant/src/json.rs|66 col 57| error[E0308]: mismatched types
--> arrow-open-variant/src/json.rs:66:57
|
66 | values_from_json(jsons_ref, array.null_count(), array.nulls(), &metadata_ref)?;
| ---------------- ^^^^^^^^^^^^^ expected arrow_buffer::NullBuffer, found NullBuffer
| |
| arguments to this function are incorrect
|
= note: NullBuffer and arrow_buffer::NullBuffer have similar names, but are actually distinct types
note: NullBuffer is defined in crate arrow_buffer
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-buffer-52.2.0/src/buffer/null.rs:30:1
|
30 | pub struct NullBuffer {
| ^^^^^^^^^^^^^^^^^^^^^
note: arrow_buffer::NullBuffer is defined in crate arrow_buffer
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-buffer-53.0.0/src/buffer/null.rs:30:1
|
30 | pub struct NullBuffer {
| ^^^^^^^^^^^^^^^^^^^^^
= note: perhaps two different versions of crate arrow_buffer are being used?
note: function defined here
--> arrow-open-variant/src/json.rs:172:4
|
172 | fn values_from_json(
| ^^^^^^^^^^^^^^^^
...
175 | null_buffer: Option<&NullBuffer>,
| --------------------------------