Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval app updates #83

Closed
wants to merge 2 commits into from
Closed

Eval app updates #83

wants to merge 2 commits into from

Conversation

guillaume-millot
Copy link
Contributor

@guillaume-millot guillaume-millot commented Apr 30, 2024

This PR contains the following fixes and improvements:

  • Updated yaml configuration file with more relevant extraction methodologies to benchmark
  • Added try catch in unstructured API to prevent Python error in case no table was extracted
  • Eval app improvements (see below)

Eval app improvements:

  • Moved PDF and REF data from right to left tabs for better clarity
  • New PDF viewer allowing to zoom in/out
  • Fixed issue with dataframes with empty headers not displayed
  • Display message when no table was extracted
  • Help tips added

Copy link
Collaborator

@kaaloo kaaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to catchup with the main branch. Dependencies in this branch are not as recent as those in main. Setting up data files etc... is non trivial. I didn't really run the eval or the eval app.

@guillaume-millot
Copy link
Contributor Author

@kaaloo thanks for lookup into it! Can you please clarify what you mean by "catching up" with the main branch? Perhaps give an example?

@kaaloo
Copy link
Collaborator

kaaloo commented Apr 30, 2024

@kaaloo thanks for lookup into it! Can you please clarify what you mean by "catching up" with the main branch? Perhaps give an example?

Yes sure, maybe this isn't the best approach, but I noticed when running poetry install on both branches that the dependencies in this branch are not up to date. If you look at the git graph you'll see it branches out from main at a commit which took place 4 weeks ago.

image

So I usually update my main branch, then merge it into my feature branch before asking for review so that we are sure that the code in your PR works with the current set of dependencies. If you try it out, you'll also see the merge conflict with eval/eval_app.py.

@guillaume-millot
Copy link
Contributor Author

@kaaloo ok thanks I see! Sorry about that, I created a new branch with hopefully all git history:
#84
Lmk what you think!

@guillaume-millot
Copy link
Contributor Author

Closing in favor of pull request #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants