Fix: Infinite loop (#9)

* use next_public env vars * fix: rm array from dependencies * use server side secret variables
dataforgoodfr · Apr 24, 2024 · 85fd4b7 · 85fd4b7
1 parent 9dc654c
commit 85fd4b7
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 18 deletions.
diff --git a/src/app/dashboard/page.tsx b/src/app/dashboard/page.tsx
@@ -170,13 +170,13 @@ const TopCountriesSection = () => {
     data: [],
     layout: {},
   });
+  const fetchGraphData = async () => {
+    const mapResponse = await fetchData("graphs", "evolution-map");
+    setMapData(mapResponse);
+  };
   useEffect(() => {
-    const fetchGraphData = async () => {
-      const mapResponse = await fetchData("graphs", "evolution-map");
-      setMapData(mapResponse);
-    };
     fetchGraphData();
-  }, [mapData]);
+  }, []);
 
   if (!mapData) {
     return <></>;

diff --git a/src/app/page.tsx b/src/app/page.tsx
@@ -191,14 +191,13 @@ const BusinessSection = () => {
     data: [],
     layout: {},
   });
-
+  const fetchGraphData = async () => {
+    const response = await fetchData("graphs", "hyper-growth-grouped");
+    setPlot(response);
+  };
   useEffect(() => {
-    const fetchGraphData = async () => {
-      const response = await fetchData("graphs", "hyper-growth-grouped");
-      setPlot(response);
-    };
     fetchGraphData();
-  }, [plot]);
+  }, []);
 
   if (!plot) {
     return <></>;

diff --git a/src/components/DashboardSection.tsx b/src/components/DashboardSection.tsx
@@ -24,6 +24,7 @@ const DashboardSection = ({
     data: [],
     layout: {},
   });
+
   const [isLoading, setIsLoading] = useState(true);
   useEffect(() => {
     const fetchGraphData = async () => {
@@ -34,7 +35,7 @@ const DashboardSection = ({
       }
     };
     fetchGraphData();
-  }, [chartData, id]);
+  }, [id]);
 
   if (!chartData) {
     return <></>;

diff --git a/src/components/JoinBlock.tsx b/src/components/JoinBlock.tsx
@@ -22,14 +22,13 @@ const IntroBlock = ({
     data: [],
     layout: {},
   });
-
+  const fetchGraphData = async () => {
+    const response = await fetchData("graphs", "alternatives");
+    setPlot(response);
+  };
   useEffect(() => {
-    const fetchGraphData = async () => {
-      const response = await fetchData("graphs", "alternatives");
-      setPlot(response);
-    };
     fetchGraphData();
-  }, [plot]);
+  }, []);
 
   if (!plot) {
     return <></>;

diff --git a/src/pages/api/chart.ts b/src/pages/api/chart.ts
@@ -1,3 +1,4 @@
+"use server";
 export const fetchData = async (apiPath: string, chartName: string) => {
 
   const dataUrl = process.env.PINKBOMBS_DATA_URL;