[Fix] Handle edge case for effective_properties in databricks_sql_table
#4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table` It was reported in #4098 that some of the specified options, like, `multiLine`, `recursiveFileLookup` and potentially more, aren't returned as `option.multiLine`, etc., but instead are expanded into full names, like, `spark.sql.dataSourceOptions.multiLine`. This PR changes lookup logic a bit, and if we can't find `option.something`, then we're looking for all options ending with `.something` (only if there are no `.` in the name). Resolves #4098
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
approved these changes
Oct 28, 2024
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/11557461282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It was reported in #4098 that some of the specified options, like,
multiLine,recursiveFileLookupand potentially more, aren't returned asoption.multiLine, etc., but instead are expanded into full names, like,spark.sql.dataSourceOptions.multiLine.This PR changes lookup logic a bit, and if we can't find
option.something, then we're looking for all options ending with.something(only if there are no.in the name).Resolves #4098
Tests
make testrun locallydocs/folderinternal/acceptance