Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Rename resources directory to products in pluginframework #4139

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Internal] Rename resources directory to products in pluginframework #4139

wants to merge 2 commits into from

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Oct 22, 2024 •
edited
Loading

Changes

We organise both resources and data sources together for each type of products, renaming resources directory to products to make it less confusing.

Tests

Existing tests.

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@tanmay-db tanmay-db requested review from a team as code owners October 22, 2024 11:56
@tanmay-db tanmay-db requested review from parthban-db, mgyucht, edwardfeng-db and rauchy and removed request for a team October 22, 2024 11:56
rauchy
rauchy approved these changes Oct 29, 2024 •
edited
Loading
View reviewed changes
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11573303086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauchy rauchy rauchy approved these changes

@parthban-db parthban-db Awaiting requested review from parthban-db parthban-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

@mgyucht mgyucht Awaiting requested review from mgyucht

@edwardfeng-db edwardfeng-db Awaiting requested review from edwardfeng-db

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanmay-db @eng-dev-ecosystem-bot @rauchy