Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Handle schema attribute in databricks_pipeline #4137

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Oct 22, 2024

Changes

The new schema attribute was added to support direct publishing mode. Besides documentation we were need to add TF schema customization as it conflicts with the target attribute.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

The new `schema` attribute was added to support direct publishing mode.  Besides
documentation we were need to add TF schema customization as it conflicts with the
`target` attribute.
@alexott alexott requested review from a team as code owners October 22, 2024 06:59
@alexott alexott requested review from rauchy and removed request for a team October 22, 2024 06:59
@alexott alexott added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit df26499 Oct 23, 2024
9 checks passed
@alexott alexott deleted the dlt-direct-publishing-mode branch October 23, 2024 10:52
rauchy added a commit that referenced this pull request Oct 23, 2024
### New Features and Improvements

 * Add `databricks_alert` resource to replace `databricks_sql_alert` ([#4051](#4051)).
 * Added resource `databricks_custom_app_integration` ([#4124](#4124)).
 * Handle `schema` attribute in `databricks_pipeline` ([#4137](#4137)).

### Bug Fixes

 * Change repo used in test ([#4122](#4122)).

### Documentation

 * Clarify that `graviton` option of `databricks_node_type` could be used on Azure ([#4125](#4125)).
 * Fix argument in example for `databricks_custom_app_integration` ([#4132](#4132)).
 * Fix for UC on AWS guide - use `databricks_aws_unity_catalog_assume_role_policy` where necessary ([#4109](#4109)).

### Exporter

 * **Breaking change**: Move `databricks_workspace_file` to a separate service ([#4118](#4118)).
 * Exclude some system schemas from export ([#4121](#4121)).
 * Use `List` + iteration instead of call to `ListAll` ([#4123](#4123)).
rauchy added a commit that referenced this pull request Oct 24, 2024
### New Features and Improvements

 * Add `databricks_alert` resource to replace `databricks_sql_alert` ([#4051](#4051)).
 * Add `databricks_query` resource instead of `databricks_sql_query` ([#4103](#4103)).
 * Added resource `databricks_custom_app_integration` ([#4124](#4124)).
 * Handle `schema` attribute in `databricks_pipeline` ([#4137](#4137)).

### Bug Fixes

 * Change repo used in test ([#4122](#4122)).

### Documentation

 * Clarify that `graviton` option of `databricks_node_type` could be used on Azure ([#4125](#4125)).
 * Fix argument in example for `databricks_custom_app_integration` ([#4132](#4132)).
 * Fix for UC on AWS guide - use `databricks_aws_unity_catalog_assume_role_policy` where necessary ([#4109](#4109)).

### Exporter

 * **Breaking change**: Move `databricks_workspace_file` to a separate service ([#4118](#4118)).
 * Exclude some system schemas from export ([#4121](#4121)).
 * Use `List` + iteration instead of call to `ListAll` ([#4123](#4123)).
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
### New Features and Improvements

* Add `databricks_alert` resource to replace `databricks_sql_alert`
([#4051](#4051)).
* Add `databricks_query` resource instead of `databricks_sql_query`
([#4103](#4103)).
* Added resource `databricks_custom_app_integration`
([#4124](#4124)).
* Handle `schema` attribute in `databricks_pipeline`
([#4137](#4137)).


### Bug Fixes

* Change repo used in test
([#4122](#4122)).


### Documentation

* Clarify that `graviton` option of `databricks_node_type` could be used
on Azure
([#4125](#4125)).
* Fix argument in example for `databricks_custom_app_integration`
([#4132](#4132)).
* Fix for UC on AWS guide - use
`databricks_aws_unity_catalog_assume_role_policy` where necessary
([#4109](#4109)).


### Exporter

* **Breaking change**: Move `databricks_workspace_file` to a separate
service
([#4118](#4118)).
* Exclude some system schemas from export
([#4121](#4121)).
* Use `List` + iteration instead of call to `ListAll`
([#4123](#4123)).

Co-authored-by: Omer Lachish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants