[PECO-1541] Optimize UC Volume ingestion #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravets-levko
requested review from
arikfr,
superdupershant,
yunbodeng-db,
andrefurlan-db,
rcypher-databricks,
jackyhu-db and
benc-db
as code owners
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: Levko Kravets <[email protected]>
kravets-levko
force-pushed
the
PECO-1541-optimize-ingestion
branch
from
85e8325
to
6ab0178
Compare
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: Levko Kravets <[email protected]>
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 93.18% 93.19% +0.01%
==========================================
Files 63 63
Lines 1525 1529 +4
Branches 266 266
==========================================
+ Hits 1421 1425 +4
Misses 41 41
Partials 63 63 ☔ View full report in Codecov by Sentry. |
|
Do we have a similar issue in the python one? I've been wondering about this for a while. |
benc-db
approved these changes
Apr 19, 2024
Just checked - in PySQL everything is fine there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we upload file to volume (SQL
PUT) file is fully loaded into memory and then sent to a storage. Similarly, when downloading a file (SQLGET) the file is fully downloaded into memory, and only then stored on disc.To optimize large file handling, Nodejs streams should be used instead.