Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PECO-964] Initial Staging Ingestion implementation #164

Merged
merged 20 commits into from
Sep 18, 2023
Merged

Conversation

nithinkdb
Copy link
Contributor

@nithinkdb nithinkdb commented Aug 21, 2023

@databricks databricks deleted a comment from github-actions bot Aug 21, 2023
@kravets-levko kravets-levko changed the title Peco 984 backup [PECO-964] Initial Staging Ingestion implementation Aug 21, 2023
@databricks databricks deleted a comment from github-actions bot Aug 21, 2023
Copy link
Contributor

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 Let's fix E2E environment to make tests passing, and only then merge it (I can confirm that tests do pass locally, but we need them to pass on CI as well)

@kravets-levko kravets-levko temporarily deployed to azure-prod September 17, 2023 20:22 — with GitHub Actions Inactive
@databricks databricks deleted a comment from github-actions bot Sep 17, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage is 13.20% of modified lines.

Files Changed Coverage
lib/DBSQLClient.ts ø
lib/DBSQLOperation/index.ts 0.00%
lib/errors/OperationStateError.ts 0.00%
lib/DBSQLSession.ts 12.50%
lib/errors/StagingError.ts 100.00%

📢 Thoughts on this report? Let us know!.

@nithinkdb nithinkdb merged commit 28e55f3 into main Sep 18, 2023
4 of 5 checks passed
@kravets-levko kravets-levko deleted the PECO-984-backup branch September 18, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants