Don't truncate BigInts

BigInts are currently converted to JS Numbers, which can't fit values over 2**53. Fixes #259
databricks · Oct 25, 2024 · fe9df56 · fe9df56
1 parent 56bd0d9
commit fe9df56
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/lib/result/ArrowResultConverter.ts b/lib/result/ArrowResultConverter.ts
@@ -205,7 +205,7 @@ export default class ArrowResultConverter implements IResultsProvider<Array<any>
     }
 
     // Return other values as is
-    return typeof value === 'bigint' ? Number(value) : value;
+    return value;
   }
 
   private convertThriftTypes(record: Record<string, any>): any {

diff --git a/lib/result/utils.ts b/lib/result/utils.ts
@@ -1,4 +1,3 @@
-import Int64 from 'node-int64';
 import {
   Schema,
   Field,
@@ -49,12 +48,7 @@ function convertJSON(value: any, defaultValue: any): any {
 }
 
 function convertBigInt(value: any): any {
-  if (typeof value === 'bigint') {
-    return Number(value);
-  }
-  if (value instanceof Int64) {
-    return value.toNumber();
-  }
+  // Do not convert a BigInt away from the BigInt type
   return value;
 }