-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Experimental: Make retry strategy configurable #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's label this as experimental, but otherwise this is fine for me.
Long-term, I think we will want to implement retries at a higher layer, after the response is deserialized, so that the retry implementation can review a deserialized error response before making a decision.
Yes right now there are retries from the SDK level and then further in HttpClient. But making that decision is a bit more involved so this PR unblocks us till we get to the point you suggested. Thanks! |
Added experimental to list of valid tags |
Ah sorry, I meant to label |
e772910
to
00ec656
Compare
### New Features and Improvements * Experimental: Make retry strategy configurable ([#363](#363)). ### Bug Fixes * CommonHttpsClient Builder - set timeout correctly ([#362](#362)). Co-authored-by: Omer Lachish <[email protected]>
Adds support to configure Retry Strategy in HttpClient. Currently only the default retry strategy is used. This strategy retries 3 times and does not have any sleep interval in between. For our use case, we would prefer using the ExponentialBackOffStrategy.
This does not affect the default behavior but gives additional options to the users.