[Fix] CommonHttpsClient Builder - set timeout correctly #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satviksr-db
changed the title
satviksr-db
force-pushed
the
fix_timeout
branch
from
44b429b
to
a37092b
Compare
satviksr-db
changed the title
satviksr-db
force-pushed
the
fix_timeout
branch
from
a37092b
to
3f071cb
Compare
satviksr-db
force-pushed
the
fix_timeout
branch
from
3f071cb
to
3755e57
Compare
avijeet95
approved these changes
Oct 17, 2024
hectorcast-db
approved these changes
Oct 18, 2024
rauchy
added a commit
that referenced
this pull request
Oct 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
### New Features and Improvements * Experimental: Make retry strategy configurable ([#363](#363)). ### Bug Fixes * CommonHttpsClient Builder - set timeout correctly ([#362](#362)). Co-authored-by: Omer Lachish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The issue was that
makeRequestConfigwas usingtimeoutbefore it was initialized, I have refactored the code to both fix and make it more error proof in the futureTests
Not possible to write UT for this as its too encapsulated, will need major refactors to be able to test via UT