Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ssafty-data api involved #2760

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Jan 12, 2025

WIP, /involved api implementing Atalya's comment from 9-Jan on issue 2734.
Added load of safety_data involved and accident tables to the main.py process cbs command line.
No fine detail testing yet. Just to verify the query parameter and returned data.
You can view the API in swagger hub

@ziv17 ziv17 requested a review from atalyaalon January 12, 2025 05:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.78846% with 67 lines in your changes missing coverage. Please review.

Project coverage is 52.89%. Comparing base (400af13) to head (91740a7).
Report is 162 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/views/safety_data/involved_query.py 54.05% 51 Missing ⚠️
anyway/flask_app.py 14.28% 12 Missing ⚠️
anyway/views/safety_data/sd_utils.py 90.47% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2760      +/-   ##
==========================================
- Coverage   53.22%   52.89%   -0.34%     
==========================================
  Files         119      124       +5     
  Lines        9924    10440     +516     
==========================================
+ Hits         5282     5522     +240     
- Misses       4642     4918     +276     
Flag Coverage Δ
unittests 52.89% <67.78%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziv17 ziv17 requested a review from citizen-dror January 12, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants