Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev into master #2554

Merged
merged 60 commits into from
Feb 14, 2024
Merged

merge dev into master #2554

merged 60 commits into from
Feb 14, 2024

Conversation

atalyaalon
Copy link
Collaborator

No description provided.

shaked-hayek and others added 27 commits January 4, 2024 17:06
Adding SegmentJunctions class.
Adding non_urban_intersection index to markers_hebrew involved_markers_hebrew vehicles_markers_hebrew
Remove test_scrape_sanity_online_walla() as it depends on actual values returned from Walla, and is not stable
Adding suburban_junctions.py and a command process suburban-junctions to load SuburbanJunction and RoadJunctionKM db tables from added file in prev commit. Removed updating these tables from accidents. Remove trailing blank from hebrew name of junction 7039 in suburban_junctions.xlsx
…dgets

2357 add junctions to suburban widgets
…che-for-streets

Bug 2547 memory issue in fill cache for streets
…ation-qualification

[Fix-2542] Fix routing and add road1 to newsflash location qualification
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 178 lines in your changes are missing coverage. Please review.

Comparison is base (dfca9c4) 52.98% compared to head (52f692c) 52.96%.
Report is 96 commits behind head on master.

Files Patch % Lines
anyway/parsers/suburban_junctions.py 0.00% 74 Missing ⚠️
anyway/models.py 31.81% 15 Missing ⚠️
...tions_widgets/accident_count_by_severity_widget.py 6.66% 14 Missing ⚠️
anyway/parsers/location_extraction.py 9.09% 10 Missing ⚠️
...ations_widgets/injured_count_by_severity_widget.py 47.36% 10 Missing ⚠️
anyway/parsers/news_flash.py 0.00% 8 Missing ⚠️
anyway/utilities.py 11.11% 8 Missing ⚠️
main.py 0.00% 8 Missing ⚠️
...ed_and_injured_count_per_age_group_widget_utils.py 70.00% 6 Missing ⚠️
...ets/no_location_widgets/vision_zero_bike_widget.py 0.00% 4 Missing ⚠️
... and 12 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2554      +/-   ##
==========================================
- Coverage   52.98%   52.96%   -0.02%     
==========================================
  Files         117      119       +2     
  Lines        9645     9828     +183     
==========================================
+ Hits         5110     5205      +95     
- Misses       4535     4623      +88     
Flag Coverage Δ
unittests 52.96% <52.53%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EliorGigi and others added 2 commits January 17, 2024 23:59
@ziv17 FYI, I checked in CBS files, they do not include to junction in to-km
shaked-hayek and others added 24 commits January 24, 2024 20:54
Remove road_segment_name from query if road_segment_id is present.
Convert segment_id to integer
Skip marker without accurate km when adding road_junction_km
…ation-qualification-wrong-id

[FIX-2542] Fix wrong id issue in location qualification
Feat 2532 - Change from SubUrbanWidget to AllLocationsWidget
…ction-in-cbs

recreate location extraction table in CBS
add option to update_cbs_location_only
@atalyaalon atalyaalon marked this pull request as ready for review February 14, 2024 16:11
@atalyaalon atalyaalon merged commit 466ca9c into master Feb 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants