Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Glossaries integration tests #1556

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Sep 17, 2024

Feature or Bugfix

  • Feature:Testing

Detail

Implement tests for Glossaries/Catalog as part of #1220

⚠️ To test glossary associations, we need resources that use the glossary terms (associate a term to a resource). Possible resources include: s3_datasets, s3_tables, s3_folders, dashboards, redshift_datasets and redshift_tables. All of which are part of other modules that might be enabled or disabled. In this PR we assume that the s3_datasets module is enabled! If it was not enabled, then the glossary tests would fail!

During the implementation several enhancement ideas came up and are collected in #1557

Tested in local with connection to real AWS deployment:
image

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx self-assigned this Sep 17, 2024
@dlpzx dlpzx force-pushed the feat/integration-tests-glossaries branch from c445e8f to 9bdb228 Compare September 18, 2024 09:18
Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments - mostly suggested additions but overall it looks good, will give a test and wait to hear your thoughts on the comments

tests_new/integration_tests/modules/catalog/conftest.py Outdated Show resolved Hide resolved
tests_new/integration_tests/modules/catalog/conftest.py Outdated Show resolved Hide resolved
tests_new/integration_tests/modules/catalog/conftest.py Outdated Show resolved Hide resolved

def test_start_reindex_catalog_handle_deletes(clientTenant):
response = start_reindex_catalog(clientTenant, handle_deletes=True)
assert_that(response).is_true()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a future enhancement (not this PR) may want a way to poll the ecs task to ensure it completes and then a way to ensure catalog populated appropriately

but out of scope for this PR imo

@noah-paige
Copy link
Contributor

Can we also add to #1557 to separate out glossary from catalog - do not think they should be the same module

@dlpzx dlpzx force-pushed the feat/integration-tests-glossaries branch from 5cef31d to 22a583c Compare September 19, 2024 08:28
@dlpzx
Copy link
Contributor Author

dlpzx commented Sep 19, 2024

Implemented changes for the PR and checked again the tests:
image

Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and tested -approving!

@dlpzx dlpzx merged commit d5226c5 into main Sep 20, 2024
9 checks passed
@dlpzx dlpzx deleted the feat/integration-tests-glossaries branch September 24, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants