Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VPC network integration tests + fix tags bug in networks #1555

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Sep 17, 2024

Feature or Bugfix

  • Feature: testing
  • Bugfix

Detail

Implement tests for Networksapi calls (inside core/vpc + listEnvironmentNetworks) as part of #1220

++ It also fixes a small bug on networks - tags were not correctly saved in the database!

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx marked this pull request as ready for review September 17, 2024 11:32
@dlpzx dlpzx self-assigned this Sep 17, 2024
Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments on changes required for tests to work on my end

tests_new/integration_tests/core/vpc/__init__.py Outdated Show resolved Hide resolved
tests_new/integration_tests/core/vpc/conftest.py Outdated Show resolved Hide resolved
tests_new/integration_tests/core/vpc/test_vpc.py Outdated Show resolved Hide resolved
tests_new/integration_tests/core/vpc/test_vpc.py Outdated Show resolved Hide resolved
Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looks good - approving!

@dlpzx dlpzx merged commit 2749ce5 into main Sep 20, 2024
9 checks passed
@dlpzx dlpzx deleted the feat/integration-tests-vpc branch September 24, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants