Add Worksheet integration tests - all except run sql query #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrkalos
requested changes
Jul 9, 2024
|
|
||
| def test_delete_worksheet(client1, group1, session_id): | ||
| ws = create_worksheet(client1, 'worksheetdelete', group1, tags=[session_id]) | ||
| assert assert_that(ws.label).is_equal_to('worksheetdelete') |
There was a problem hiding this comment.
- double assert
- also it might be nicer to
assert_that(ws).contains_entry(label='worksheetdelete')because if it fails it will print a message and will show the entire payload ofwswhich might be useful for debugging
Comment on lines
34
to
35
| assert_that(ws.SamlAdminGroupName).is_equal_to(group1) | ||
| assert_that(ws.worksheetUri).is_equal_to(worksheet1.worksheetUri) |
There was a problem hiding this comment.
nit: same reason as above assert_that(ws).contains_entry(SamlAdminGroupName=group1, worksheetUri=worksheet1.worksheetUri)
petrkalos
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Integration tests for all API calls except for run athena sql - the draft is commented out in the second commit; but to unblock this PR I removed them
Relates
#1220
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.