Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(types): remove QuorumSingsVerifier #727

Merged
merged 2 commits into from
Feb 9, 2024
Merged

refactor(types): remove QuorumSingsVerifier #727

merged 2 commits into from
Feb 9, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Jan 29, 2024

Issue being fixed or feature implemented

Removed QuorumSigsVerifier which was just adding unnecessary complexity to the source code

What was done?

Removed QuorumSigsVerifier, moved verification code to QuorumSignData.

How Has This Been Tested?

Github Actions

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Base automatically changed from feat/vote-extension-sign-id to v0.14-dev January 31, 2024 10:30
@lklimek lklimek force-pushed the refactor/remove-QuorumSingsVerifier branch from 8a089d7 to aa99653 Compare January 31, 2024 13:34
@lklimek lklimek marked this pull request as ready for review January 31, 2024 13:38
@lklimek lklimek requested a review from shumkov January 31, 2024 16:00
@lklimek lklimek enabled auto-merge (squash) February 8, 2024 15:41
shumkov
shumkov approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit fdbfa1f into v0.14-dev Feb 9, 2024
14 of 15 checks passed
@lklimek lklimek deleted the refactor/remove-QuorumSingsVerifier branch March 13, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

@shotonoff shotonoff Awaiting requested review from shotonoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lklimek @shumkov