-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(statesync): implement statesync peer manager #648
refactor(statesync): implement statesync peer manager #648
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
PR title is confusing, we already have peer manager implemented in p2p |
…ync-peer-manager' into refactor/td-162-implement-statesync-peer-manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is ready to new round review
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Issue being fixed or feature implemented
This is PR is related to the task TD-162:
Each module that communicates with p2p peers has its own simple peer manager implementation. Usually the code is placed into a reactor. As a result of the refactoring, peer management has been moved out of the reactor and into a separate component.
The component must listen to peer
up
anddown
events and register the peer into the peer store or remove it.What was done?
statesync
channel descriptors in p2p moduleSnapshotClient
interface and implement itLightBlockRepository
How Has This Been Tested?
Add a couple unit-tests
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only