Skip to content

chore: fix linter issues #1686

chore: fix linter issues

chore: fix linter issues #1686

Triggered via pull request January 30, 2024 09:04
Status Failure
Total duration 2m 57s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 14 warnings
golangci-lint: internal/jsontypes/jsontypes_test.go#L111
string `"}}` has 5 occurrences, make it a constant (goconst)
golangci-lint: internal/jsontypes/jsontypes_test.go#L137
string `{"type":"test/PointerType","value":{"field":"` has 3 occurrences, make it a constant (goconst)
golangci-lint: scripts/metricsgen/metricsgen_test.go#L114
string `type Metrics struct {
golangci-lint: internal/libs/tempfile/tempfile_test.go#L71
string `/tmp/` has 4 occurrences, make it a constant (goconst)
golangci-lint: internal/pubsub/query/query_test.go#L111
string `tx|date=` has 3 occurrences, make it a constant (goconst)
golangci-lint: types/validator_address_test.go#L20
string `@fqdn.address.com:1234` has 4 occurrences, make it a constant (goconst)
golangci-lint: types/validator_set_test.go#L308
string `2C26B4 BAA5A0 FCDE2B 2C26B4 BAA5A0 FCDE2B 2C26B4 BAA5A0 FCDE2B 2C26B4 BAA5A0 FCDE2B 2C26B4 BAA5A0 FCDE2B ` has 6 occurrences, make it a constant (goconst)
golangci-lint: types/validator_address.go#L64
string `tcp://` has 7 occurrences, make it a constant (goconst)
golangci-lint: internal/p2p/address_test.go#L163
string `memory:` has 4 occurrences, make it a constant (goconst)
golangci-lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
golangci-lint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
golangci-lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: technote-space/get-diff-action@v6, actions/setup-go@v2, actions/checkout@v2, actions/cache@v2, actions/[email protected], golangci/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
golangci-lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2, actions/cache@v2, actions/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
golangci-lint: internal/jsontypes/jsontypes.go#L102
empty-block: this block is empty, you can remove it (revive)
golangci-lint: internal/libs/queue/queue_test.go#L104
redefines-builtin-id: redefinition of the built-in function cap (revive)
golangci-lint: internal/libs/queue/queue.go#L201
redefines-builtin-id: redefinition of the built-in function cap (revive)
golangci-lint: internal/libs/protoio/io.go#L70
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
golangci-lint: scripts/metricsgen/metricsgen.go#L171
empty-block: this block is empty, you can remove it (revive)
golangci-lint: libs/rand/random.go#L32
superfluous-else: if block ends with a continue statement, so drop this else and outdent its block (revive)
golangci-lint: internal/libs/clist/clist.go#L201
redefines-builtin-id: redefinition of the built-in function len (revive)
golangci-lint: libs/bits/bit_array_test.go#L192
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
golangci-lint: libs/bits/bit_array_test.go#L211
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
golangci-lint: dash/llmq/llmq_test.go#L245
unused-parameter: parameter 'sigHash' seems to be unused, consider removing or renaming it as _ (revive)