chore: minor improvements: logging, comments, locks #1676
Annotations
10 errors and 12 warnings
golangci-lint:
cmd/contract_tests/main.go#L7
import 'github.com/snikch/goodman/hooks' is not allowed from list 'Main' (depguard)
|
golangci-lint:
cmd/contract_tests/main.go#L8
import 'github.com/snikch/goodman/transaction' is not allowed from list 'Main' (depguard)
|
golangci-lint:
libs/workerpool/worker_pool.go#L229
empty-block: this block is empty, you can remove it (revive)
|
golangci-lint:
libs/workerpool/worker.go#L6
import 'github.com/dashpay/tenderdash/libs/log' is not allowed from list 'Main' (depguard)
|
golangci-lint:
libs/workerpool/worker_pool.go#L8
import 'github.com/sasha-s/go-deadlock' is not allowed from list 'Main' (depguard)
|
golangci-lint:
libs/workerpool/worker_pool.go#L10
import 'github.com/dashpay/tenderdash/libs/log' is not allowed from list 'Main' (depguard)
|
golangci-lint:
libs/workerpool/worker_pool_test.go#L10
import 'github.com/sasha-s/go-deadlock' is not allowed from list 'Main' (depguard)
|
golangci-lint:
libs/workerpool/worker_pool_test.go#L11
import 'github.com/stretchr/testify/require' is not allowed from list 'Main' (depguard)
|
golangci-lint:
libs/workerpool/worker_pool_test.go#L13
import 'github.com/dashpay/tenderdash/internal/test/require' is not allowed from list 'Main' (depguard)
|
golangci-lint:
scripts/metricsgen/metricsdiff/metricsdiff_test.go#L8
import 'github.com/dashpay/tenderdash/scripts/metricsgen/metricsdiff' is not allowed from list 'Main' (depguard)
|
golangci-lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
golangci-lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
golangci-lint:
abci/tests/server/client.go#L94
unused-parameter: parameter 'dataExp' seems to be unused, consider removing or renaming it as _ (revive)
|
golangci-lint:
abci/client/client.go#L105
receiver-naming: receiver name r should be consistent with previous receiver name reqResp for requestAndResponse (revive)
|
golangci-lint:
abci/client/grpc_client.go#L50
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
golangci-lint:
abci/client/grpc_client.go#L125
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
golangci-lint:
internal/pubsub/pubsub.go#L161
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
golangci-lint:
internal/pubsub/pubsub.go#L197
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
golangci-lint:
internal/pubsub/pubsub.go#L225
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
golangci-lint:
internal/pubsub/pubsub.go#L260
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
golangci-lint:
internal/p2p/conn/connection.go#L575
empty-block: this block is empty, you can remove it (revive)
|
golangci-lint:
dash/core/mock.go#L121
unused-parameter: parameter 'filter' seems to be unused, consider removing or renaming it as _ (revive)
|