chore: minor improvements: logging, comments, locks #1674

Triggered via pull request January 16, 2024 12:32

lklimek

synchronize #726

fix-mempool-spam

Status Failure

Total duration 1m 10s

Artifacts –

lint.yml

on: pull_request

10 errors and 12 warnings

golangci-lint: libs/bytes/bytes_test.go#L9

import 'github.com/stretchr/testify/assert' is not allowed from list 'Main' (depguard)

golangci-lint: libs/bytes/marshal_test.go#L9

import 'github.com/stretchr/testify/assert' is not allowed from list 'Main' (depguard)

golangci-lint: scripts/metricsgen/metricsgen.go#L171

empty-block: this block is empty, you can remove it (revive)

golangci-lint: cmd/abcidump/parser/parser.go#L7

import 'github.com/gogo/protobuf/jsonpb' is not allowed from list 'Main' (depguard)

golangci-lint: cmd/abcidump/parser/parser.go#L8

import 'github.com/gogo/protobuf/proto' is not allowed from list 'Main' (depguard)

golangci-lint: cmd/abcidump/parser/parser.go#L10

import 'github.com/dashpay/tenderdash/abci/types' is not allowed from list 'Main' (depguard)

golangci-lint: cmd/abcidump/parser/types.go#L8

import 'github.com/gogo/protobuf/proto' is not allowed from list 'Main' (depguard)

golangci-lint: cmd/abcidump/parser/types.go#L10

import 'github.com/dashpay/tenderdash/abci/types' is not allowed from list 'Main' (depguard)

golangci-lint: cmd/abcidump/parser/types.go#L11

import 'github.com/dashpay/tenderdash/proto/tendermint/p2p' is not allowed from list 'Main' (depguard)

golangci-lint: cmd/abcidump/parser/parser_test.go#L8

import 'github.com/gogo/protobuf/proto' is not allowed from list 'Main' (depguard)

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

golangci-lint: abci/tests/server/client.go#L94

unused-parameter: parameter 'dataExp' seems to be unused, consider removing or renaming it as _ (revive)

golangci-lint: abci/client/client.go#L105

receiver-naming: receiver name r should be consistent with previous receiver name reqResp for requestAndResponse (revive)

golangci-lint: abci/client/grpc_client.go#L50